Dynamic priority fee by GabrielMartinezRodriguez · Pull Request #570 · HappyChainDevs/happychain

GabrielMartinezRodriguez · 2025-03-27T13:24:08Z

Linked Issues

closes https://linear.app/happychain/issue/HAPPY-372/estimate-maxpriorityfeepergas

Description

This PR introduces a new dynamic priority fee mechanism by adding support for fee history retrieval and updating transaction configuration accordingly

Include all relevant context (but no need to repeat the issue's content).
Draw attention to new, noteworthy & unintuitive elements.

Toggle Checklist

Checklist

Basics

B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
B2. This PR is not so big that it should be split & addresses only one concern.
B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

C1. Builds and passes tests.
C2. The code is properly parameterized & compatible with different environments (e.g. local,
testnet, mainnet, standalone wallet, ...).
C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

C4. I have performed a thorough self-review of my code after submitting the PR,
and have updated the code & comments accordingly.

Architecture & Documentation

D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
comments.
D3. If appropriate, the general architecture of the code is documented in a code comment or
in a Markdown document.
D4. An appropriate Changeset has been generated (and committed) for changes that touch npm published packages (currently packages/core and packages/react), see here for more info.

cloudflare-workers-and-pages · 2025-03-27T13:24:10Z

Deploying happychain with Cloudflare Pages

Latest commit:	`1356e03`
Status:	🚫 Deploy failed.

View logs

GabrielMartinezRodriguez · 2025-03-27T13:24:27Z

Randomness monitor service #584
Txm traces #521
fix(txm): returned nonce queue order #578
fix(txm): not process the same block multiple times #577
Fix: Viem sends random undefined blocks #575
fix(txm): heap out of memory #573
Avoid initiating new attempts if the gas conditions persist unchanged #571
Dynamic priority fee #570 👈 (View in Graphite)
TXM: Rpc liveness #562
fix(txm): nonce gap #561
PoC: Add metrics to TXM #503
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR introduces a new dynamic priority fee mechanism by adding support for fee history retrieval and updating transaction configuration accordingly.

Adds safeFeeHistory method to safely wrap fee history queries in the common viem client utility.
Updates TransactionManager configuration to use a new gas property with explicit EIP-1559 and fee parameters.
Modifies GasPriceOracle to use the calculated target priority fee when suggesting gas fees.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File	Description
support/common/lib/utils/safeViemClients.ts	Adds safeFeeHistory wrapper method with error handling
packages/txm/lib/TransactionManager.ts	Introduces a new gas config block and updates fee parameters
packages/txm/lib/GasPriceOracle.ts	Updates fee calculations and introduces asynchronous block handling
apps/randomness/src/index.ts	Updates configuration to use the new gas configuration format

Files not reviewed (1)

contracts/src/happy-accounts/samples/executors/BatchCallExecutor.sol: Language not supported

packages/txm/lib/TransactionManager.ts

packages/txm/lib/GasPriceOracle.ts

linear · 2025-03-27T15:22:05Z

HAPPY-372 Estimate `maxPriorityFeePerGas`

Implement a mechanism to predict the recommended maxPriorityFeePerGas while ensuring a minimum value is stabilized to guarantee that the sequencer always accepts the new block that includes our transaction when recommitting.

Context: #416 (comment)

aodhgan · 2025-04-01T21:06:21Z

contracts/deployments/unknown/mocks/deployment.json

@@ -0,0 +1,8 @@
+{
+  "HappyCounter": "0x8D45cAd49F37CC512DAFFE6700ddc98084867E68",
+  "MockGasBurner": "0xdA504Bb1b736b04A5Aec28fD5d693Ad7447Ad438",


dunno whats going on with the network unknown, likely a mismatch with chainId's. dont think the contracts are changed so can probably just remove the deployments completely

aodhgan · 2025-04-01T21:14:49Z

support/common/lib/utils/safeViemClients.ts

    safeGetTransactionCount: (
        ...args: Parameters<ViemPublicClient["getTransactionCount"]>
    ) => ResultAsync<Awaited<ReturnType<ViemPublicClient["getTransactionCount"]>>, GetTransactionCountErrorType>
+    safeFeeHistory: (


nit: lets fully qualify this -> safeGetFeeHistory, so there isnt any confusion as to the underlying RPC method

aodhgan · 2025-04-01T21:21:59Z

packages/txm/lib/GasPriceOracle.ts

@@ -37,7 +39,7 @@ export class GasPriceOracle {
        this.onNewBlock(block)


think we need to await here, now that its async?

GabrielMartinezRodriguez mentioned this pull request Mar 27, 2025

fix(txm): nonce gap #561

Merged

11 tasks

GabrielMartinezRodriguez mentioned this pull request Mar 27, 2025

TXM: Rpc liveness #562

Merged

11 tasks

GabrielMartinezRodriguez marked this pull request as ready for review March 27, 2025 13:24

GabrielMartinezRodriguez requested a review from Copilot March 27, 2025 13:24

Copilot AI reviewed Mar 27, 2025

View reviewed changes

packages/txm/lib/TransactionManager.ts Outdated Show resolved Hide resolved

packages/txm/lib/GasPriceOracle.ts Outdated Show resolved Hide resolved

GabrielMartinezRodriguez mentioned this pull request Mar 27, 2025

Avoid initiating new attempts if the gas conditions persist unchanged #571

Merged

11 tasks

GabrielMartinezRodriguez force-pushed the gabriel/txm-rpc-liveness branch from db14c74 to db7aedd Compare March 27, 2025 14:41

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from c10757e to f9acbe6 Compare March 27, 2025 14:41

GabrielMartinezRodriguez force-pushed the gabriel/txm-rpc-liveness branch from db7aedd to cc22eb4 Compare March 27, 2025 14:51

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from f9acbe6 to 22fd6dd Compare March 27, 2025 14:51

GabrielMartinezRodriguez changed the title ~~feat(txm): dynamic priority fee~~ Dynamic priority fee Mar 27, 2025

GabrielMartinezRodriguez self-assigned this Mar 27, 2025

GabrielMartinezRodriguez added the reviewing-1 Ready for, or undergoing first-line review label Mar 27, 2025

GabrielMartinezRodriguez force-pushed the gabriel/txm-rpc-liveness branch from cc22eb4 to 32771ef Compare March 27, 2025 15:39

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from 22fd6dd to 6e7f328 Compare March 27, 2025 15:39

not-reed approved these changes Mar 27, 2025

View reviewed changes

GabrielMartinezRodriguez mentioned this pull request Mar 28, 2025

fix(txm): heap out of memory #573

Merged

11 tasks

GabrielMartinezRodriguez force-pushed the gabriel/txm-rpc-liveness branch from 32771ef to 5801281 Compare March 31, 2025 09:54

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from 6e7f328 to a1cf861 Compare March 31, 2025 09:54

This was referenced Mar 31, 2025

Fix: Viem sends random undefined blocks #575

Merged

Txm traces #521

Merged

PoC: Add metrics to TXM #503

Merged

fix(txm): not process the same block multiple times #577

Merged

fix(txm): returned nonce queue order #578

Merged

aodhgan reviewed Apr 1, 2025

View reviewed changes

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch 3 times, most recently from b2d5509 to ed80362 Compare April 8, 2025 13:01

GabrielMartinezRodriguez force-pushed the gabriel/txm-rpc-liveness branch from b09dfe0 to 6ed51b5 Compare April 10, 2025 07:52

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from ed80362 to a1fd330 Compare April 10, 2025 07:52

GabrielMartinezRodriguez force-pushed the gabriel/txm-rpc-liveness branch from 6ed51b5 to a3d1d4d Compare April 10, 2025 08:00

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from a1fd330 to 150a533 Compare April 10, 2025 08:01

GabrielMartinezRodriguez force-pushed the gabriel/txm-rpc-liveness branch from a3d1d4d to 0c8f54d Compare April 10, 2025 08:37

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from 150a533 to bdd1d5c Compare April 10, 2025 08:37

GabrielMartinezRodriguez force-pushed the gabriel/txm-rpc-liveness branch from 0c8f54d to d72d783 Compare April 10, 2025 08:51

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from bdd1d5c to d5bfe00 Compare April 10, 2025 08:51

GabrielMartinezRodriguez force-pushed the gabriel/txm-rpc-liveness branch from d72d783 to 75f46bf Compare April 10, 2025 09:12

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from d5bfe00 to 44f4247 Compare April 10, 2025 09:12

GabrielMartinezRodriguez force-pushed the gabriel/txm-rpc-liveness branch from 75f46bf to c884815 Compare April 10, 2025 09:56

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from 44f4247 to 1f2858b Compare April 10, 2025 09:56

GabrielMartinezRodriguez mentioned this pull request Apr 10, 2025

Txm transactions support arbitrary calldata #596

Merged

11 tasks

Base automatically changed from gabriel/txm-rpc-liveness to master April 10, 2025 20:11

GabrielMartinezRodriguez added 6 commits April 13, 2025 23:28

feat(txm): dynamic priority fee

fe1eb87

chore(txm): code review

ce03e8d

fix(txm): fixed tests

a200a91

chore(txm): renamed safeGetFeeHistory

c0dbd8b

chore(contracts): remove unknown folder

4f5219b

chore(txm): await onNewBlock on start

1356e03

GabrielMartinezRodriguez force-pushed the gabriel/dynamic-priority-fee branch from 1f2858b to 1356e03 Compare April 13, 2025 21:30

GabrielMartinezRodriguez merged commit b0c88f3 into master Apr 13, 2025
2 of 4 checks passed

GabrielMartinezRodriguez deleted the gabriel/dynamic-priority-fee branch April 13, 2025 21:35

This was referenced Apr 21, 2025

feat(txm): transactions with value #647

Merged

Faucet service & Iframe integration #661

Merged

feat: deploy faucet #668

Merged

feat(randomness): drand prune #693

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamic priority fee#570

Dynamic priority fee#570
GabrielMartinezRodriguez merged 6 commits intomasterfrom
gabriel/dynamic-priority-fee

GabrielMartinezRodriguez commented Mar 27, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

GabrielMartinezRodriguez commented Mar 27, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

linear bot commented Mar 27, 2025

Uh oh!

aodhgan Apr 1, 2025

Uh oh!

aodhgan Apr 1, 2025 •

edited

Loading

Uh oh!

aodhgan Apr 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -37,7 +39,7 @@ export class GasPriceOracle {
		this.onNewBlock(block)

Conversation

GabrielMartinezRodriguez commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked Issues

Description

Checklist

Basics

Correctness

Architecture & Documentation

Uh oh!

cloudflare-workers-and-pages bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying happychain with Cloudflare Pages

Uh oh!

GabrielMartinezRodriguez commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

linear bot commented Mar 27, 2025

Uh oh!

aodhgan Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

aodhgan Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aodhgan Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GabrielMartinezRodriguez commented Mar 27, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Mar 27, 2025 •

edited

Loading

GabrielMartinezRodriguez commented Mar 27, 2025 •

edited

Loading

aodhgan Apr 1, 2025 •

edited

Loading